[SYCL] Fix LastDeviceIds assignment for Platform w/o device #5695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/summary:run |
1 similar comment
|
/summary:run |
|
Hi @bso-intel could you please review? |
alexbatashev
previously approved these changes
Mar 4, 2022
Why these llvm-test-suite tests are failing? |
When platform doesn't have device LastDeviceIds[] for the platform will stay 0 that will affect device enumeration for the next platforms. Now we do adjustment of that if no devices for platform was obtained from backend. Testing: E2E test in llvm-test_suite/SYCL/Regression/device_num.cpp when Mesa is installed Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
KseniyaTikhomirova
dismissed stale reviews from alexbatashev and bso-intel
via
ca28a05
KseniyaTikhomirova
force-pushed
the
test_device_num_adjust
branch
from
331aba1 to
ca28a05
Compare
Hi @bader unfortunately, it is not clear right now, can not reproduce it locally. These tests were changed 2 days ago and have corresponding RT change, could be that not both changes were picked up for testing. Did rebase of my commit to verify this assumption. |
|
Okay. Please, use |
|
Hi @bso-intel , @alexbatashev, your reviews were dismissed after rebase, could you please take a look again? |
alexbatashev
approved these changes
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When platform has no devices LastDeviceIds[] for the platform will stay 0 that will affect device enumeration for the next platforms.
Now we do adjustment if no devices for platform was obtained from backend.
Testing: issue is found/partly covered by E2E test in llvm-test_suite/SYCL/Regression/device_num.cpp
Signed-off-by: Tikhomirova, Kseniya [email protected]