Skip to content

[SYCL] Declare __devicelib_assert_read only when fallback assert is enabled #5698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

s-kanaev
Copy link
Contributor

@s-kanaev s-kanaev commented Mar 1, 2022

No description provided.

@s-kanaev s-kanaev requested a review from a team as a code owner March 1, 2022 14:54
@s-kanaev s-kanaev requested a review from againull March 1, 2022 14:54
againull
againull previously approved these changes Mar 3, 2022
@bader
Copy link
Contributor

bader commented Mar 10, 2022

@s-kanaev, please, give this PR better title and description, which do not force reader to dig into source code and other GitHub PRs.

@s-kanaev s-kanaev requested a review from againull March 10, 2022 11:59
@s-kanaev s-kanaev changed the title [SYCL] Add missing change past #4694 [SYCL] Define __devicelib_assert_read only when fallback assert is enabled Mar 10, 2022
@s-kanaev s-kanaev changed the title [SYCL] Define __devicelib_assert_read only when fallback assert is enabled [SYCL] Declare __devicelib_assert_read only when fallback assert is enabled Mar 10, 2022
@s-kanaev
Copy link
Contributor Author

please, give this PR better title and description

done

@bader
Copy link
Contributor

bader commented Mar 11, 2022

@s-kanaev, please, address pre-commit failures.

@github-actions github-actions bot added the Stale label Sep 28, 2022
@github-actions github-actions bot closed this Oct 28, 2022
againull added a commit to againull/llvm that referenced this pull request Apr 1, 2024
…nabled

Try to reland PR: intel#5698

Author: Sergei Kanaev, s-kanaev
againull added a commit that referenced this pull request Apr 2, 2024
…nabled (#13241)

Try to reland PR: #5698

Author: Sergei Kanaev, s-kanaev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants