[SYCL][PI] Fix PI unittests after PI API name changes #572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adapt namechanges, e.g., `cl::sycl::detail::pi::piInitialize` to `cl::sycl::detail::pi::initialize`. Signed-off-by: Bjoern Knafla <[email protected]>
Fix compiler warning in PI unittests: ```sh warning: comparison between signed and unsigned integer expressions [-Wsign-compare] ``` Signed-off-by: Bjoern Knafla <[email protected]>
bader
approved these changes
Aug 29, 2019
Ruyk
approved these changes
Aug 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the CMake flag
-DLLVM_BUILD_TESTS=ONunittests are not automatically build and run with thecheck-alltarget. Due to that changes in the PI API names have not been applied to the PI unittests.This PR adapts PI API name changes to the PI unittests and fixes a compiler warning in two different commits (both signed).