-
Notifications
You must be signed in to change notification settings - Fork 787
[SYCL][ESIMD] Move some ESIMD APIs outside of experimental namespace #5729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Sergey Dmitriev <[email protected]>
/verify with intel/llvm-test-suite#892 |
1 similar comment
/verify with intel/llvm-test-suite#892 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please move floor, ceil, trunc out of experimental as a separate patch.
@intel/llvm-reviewers-runtime, please review accessor.hpp - just few lines, would really appreciate if you could to this ASAP, as the patch is giant and can have conflicts very soon. |
Unexpected failures on llvm-test-suite will disappear once intel/llvm-test-suite#892 is merged, '/verify with' testing has completed successfully for that patch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
accessor.hpp - LGTM
Building with |
Signed-off-by: Sergey Dmitriev [email protected]