Skip to content

[SYCL][ESIMD] Move some ESIMD APIs outside of experimental namespace #5729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 9, 2022

Conversation

sndmitriev
Copy link
Contributor

Signed-off-by: Sergey Dmitriev [email protected]

@sndmitriev sndmitriev marked this pull request as ready for review March 5, 2022 07:38
@sndmitriev sndmitriev requested review from a team as code owners March 5, 2022 07:38
@sndmitriev
Copy link
Contributor Author

/verify with intel/llvm-test-suite#892

1 similar comment
@sndmitriev
Copy link
Contributor Author

/verify with intel/llvm-test-suite#892

Copy link
Contributor

@kbobrovs kbobrovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please move floor, ceil, trunc out of experimental as a separate patch.

@kbobrovs
Copy link
Contributor

kbobrovs commented Mar 9, 2022

@intel/llvm-reviewers-runtime, please review accessor.hpp - just few lines, would really appreciate if you could to this ASAP, as the patch is giant and can have conflicts very soon.

@sndmitriev
Copy link
Contributor Author

Unexpected failures on llvm-test-suite will disappear once intel/llvm-test-suite#892 is merged, '/verify with' testing has completed successfully for that patch.

Copy link
Contributor

@vladimirlaz vladimirlaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accessor.hpp - LGTM

@kbobrovs kbobrovs merged commit c557d78 into intel:sycl Mar 9, 2022
@sndmitriev sndmitriev deleted the sndmitriev/esimd-experimental branch March 9, 2022 15:35
@dongkyunahn-intel
Copy link
Contributor

Building with ESIMD_EMULATOR support fails (--enable-esimd-emulator) as header file path in pi_esimd_emulator.hpp is not updated accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants