[SYCL] Ensure correct errc thrown for unassociated placeholder accessor (4.7.6.9) #5737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…placeholder accessor (4.7.6.9) Signed-off-by: Chris Perkins <[email protected]>
|
/verify with intel/llvm-test-suite#890 |
cperkinsintel
requested review from
v-klochkov and
sergey-semenov
and removed request for
v-klochkov
|
@cperkinsintel It seems like this change can be covered by a unit test. Could you please add one? |
|
@sergey-semenov - I forgot to update the description. I already made a test for it here, this is also waiting for review: intel/llvm-test-suite#890 |
|
Right, I meant that since handling this error case is limited to the DPCPP runtime component (i.e. does not require running any device code), a unit test would probably be a better way to verify this as opposed to a full on E2E test. |
Signed-off-by: Chris Perkins <[email protected]>
Signed-off-by: Chris Perkins <[email protected]>
Signed-off-by: Chris Perkins <[email protected]>
cperkinsintel
commented
Apr 5, 2022
Signed-off-by: Chris Perkins <[email protected]>
steffenlarsen
approved these changes
Apr 7, 2022
|
/verify with intel/llvm-test-suite#890 |
|
This got overlooked. All tests are passing. Needs merging. |
pvchupin
pushed a commit
to intel/llvm-test-suite
that referenced
this pull request
Jun 18, 2022
Update test to check for correct errc when attempting to use an unassociated placeholder accessor. Test for PR intel/llvm#5737 Signed-off-by: Chris Perkins [email protected]
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…#890) Update test to check for correct errc when attempting to use an unassociated placeholder accessor. Test for PR intel#5737 Signed-off-by: Chris Perkins [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a simple fix for ensuring correct errc is thrown for an unassociated placeholder accessor (4.7.6.9)
Signed-off-by: Chris Perkins [email protected]
Note that this fix is not complete. It only addresses the most common cases. There are still cases where an unassociated placholder accessor could get by undetected and crash in the kernel. Unfortunately, the fix for those cases is not trivial. I have the outlines of a fix, but it would be disruptive, too disruptive for such a low priority fix. I will open a ticket about it and discuss it with various stakeholders.
Expanded testing to cover this here: intel/llvm-test-suite#890