[SYCL] Fix post-commit build in tools

[alexbatashev]

Warnings come from community code. Mark community headers as system to suppress warnings.

[pvchupin]

Observing the same in downstream.
@alexbatashev, why these are not appearing in community builds?
And what's wrong with testing? Clearly your change is not connected to issues.

[alexbatashev]

@pvchupin we disabled warnings in community code. Too many of them, and they usually blocked pulldown.

[pvchupin]

@alexbatashev, where exactly these were disabled?
Downstream (in product builds) we treat them as errors and builds are ok, these new warnings are the new ones that I've noticed and they cause a problem there as well as in post-commit here.
My question is why suppressing them? Same community headers that you say are responsible for warnings are getting included in many places in community code build and do not produce warnings.

[alexbatashev]

Tagging @bader

@pvchupin we only enable this option in CI:

llvm/sycl/CMakeLists.txt

Line 37 in 6f81972

if(SYCL_ENABLE_WERROR)

Edit also note, that different compilers expose different warnings by default.

[pvchupin]

Is there any other way to fix this, w/o treating community headers as system headers?

[alexbatashev]

Is there any other way to fix this, w/o treating community headers as system headers?

Submit a fix to community and wait for pulldown

[bader]

To be honest, this looks very strange. From my experience, LLVM community regularly cleans warnings in the code especially for the code in core LLVM libraries with many users. The more users the more likely it's being noticed and fixed.
Do you have any idea why it's not addressed by the community?

[alexbatashev]

To be honest, this looks very strange. From my experience, LLVM community regularly cleans warnings in the code especially for the code in core LLVM libraries with many users. The more users the more likely it's being noticed and fixed. Do you have any idea why it's not addressed by the community?

I don't know

[pvchupin]

My concern was the same as @bader. It's not clear to me why same headers are not producing warnings in

• community code (clearly there are many places where "llvm/Support/CommandLine.h" is included)
• downstream code (ditto)

I'm not familiar with the tools in question (sycl-prof, sycl-sanitize), but somehow only these tools are producing warnings.
Having said that, I'm ok with this change to go in to fix post-commit issues, but I think there are some design questions to answer.

[pvchupin]

Submit a fix to community and wait for pulldown

We can try to make the same fix here... I just have doubts that something is wrong in CommandLine.h if you'd like to fix that.

[bader]

@intel/llvm-reviewers-runtime, ping.