[CI] Install sudo inside containers #5760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bader
previously approved these changes
Mar 9, 2022
|
@alexbatashev, shouldn't we run CI Containers job in pre-commit for changes like this? |
Good point. Fixed. |
bader
approved these changes
Mar 9, 2022
bader
reviewed
Mar 9, 2022
Comment on lines
+13
to
+14
| - 'devops/scripts/install_drivers.sh' | ||
| - 'devops/scripts/install_build_tools.sh' |
There was a problem hiding this comment.
Idea for future refactoring. It make sense either move scripts for configuring containers to devops/containers/** or come up with some naming scheme, so we can use wildcards to reduce amount of changes in this file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally make sure pre-commit builds are run for changes like this.