Skip to content

[CI] Disable meaningless build jobs #5762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 9, 2022
Merged

[CI] Disable meaningless build jobs #5762

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57c9161
[CI] Disable meaningless build jobs
Mar 9, 2022
61dc9a3
address feedback
Mar 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/sycl_precommit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,16 @@ on:
pull_request:
branches:
- sycl
# Do not run builds if changes are only in the following locations
paths-ignore:
- 'devops/containers/**'
- 'devops/scripts/install_drivers.sh'
- 'devops/scripts/install_build_tools.sh'
- 'sycl/doc/**'
- 'sycl/gdb/**'
- 'clang/docs/**'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- 'clang/docs/**'
- 'sycl/gdb/**'
- 'sycl/examples/**'
- 'clang/docs/**'
- 'buildbot/**'
- '*.md' # not sure if it's correct syntax, but it aims to ignore changes in README.md, CONTRIBUTING.md, etc. Ideally we should ignore changes in any Markdown, ReST, .txt files in any sub-directory.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about buildbot files and sycl/examples?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Files in both directories can affect builds, so, I'd prefer them to go through full build cycle.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which buildbot files affect GitHub actions builds?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

configure.py

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should move scripts shared between different CI systems to a separate directory.

- '**.md'
- '**.rst'

jobs:
lint:
Expand Down