[Driver][SYCL] Allow for preprocessing to succeed with coding errors #5784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typical behavior is to allow for preprocessing to succeed regardless of the input file. When building with -fsycl, this is not possible due to the requirement to generate the integration ehader and footer before we do the actual preprocessing step. Adjust the compilation when preprocessing is requested to allow for the device compilation to fail and continue to perform the preprocessing steps.
|
@intel/dpcpp-clang-driver-reviewers, ping |
hchilama
previously approved these changes
Mar 21, 2022
bader
reviewed
Mar 22, 2022
|
@intel/dpcpp-l0-pi-reviewers, @intel/llvm-reviewers-runtime, @alexbatashev, FYI. Take a look at https://github.com/intel/llvm/runs/5504777351?check_suite_focus=true. It doesn't look like this patch might cause these failures. |
|
@hchilama, please take another look. |
hchilama
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typical behavior is to allow for preprocessing to succeed regardless of
the input file. When building with -fsycl, this is not possible due to
the requirement to generate the integration ehader and footer before we do
the actual preprocessing step.
Adjust the compilation when preprocessing is requested to allow for
the device compilation to fail and continue to perform the preprocessing
steps.