Skip to content

[SYCL][ESIMD] Move rounding functions out of experimental namespace #5785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2022
Merged

[SYCL][ESIMD] Move rounding functions out of experimental namespace #5785

merged 1 commit into from
Mar 11, 2022

Conversation

sndmitriev
Copy link
Contributor

Signed-off-by: Sergey Dmitriev [email protected]

@sndmitriev sndmitriev requested a review from a team as a code owner March 11, 2022 04:03
@sndmitriev
Copy link
Contributor Author

/verify with intel/llvm-test-suite#914

kbobrovs
kbobrovs approved these changes Mar 11, 2022
View reviewed changes
Copy link
Contributor

@kbobrovs kbobrovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sndmitriev
Copy link
Contributor Author

SYCL :: ESIMD/ext_math.cpp is expected to fail for this patch. It will start passing once intel/llvm-test-suite#914 is merged.

@bader bader merged commit b2ee289 into intel:sycl Mar 11, 2022
@sndmitriev sndmitriev deleted the sndmitriev/esimd-exp-math branch March 11, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbobrovs kbobrovs kbobrovs approved these changes

@v-klochkov v-klochkov Awaiting requested review from v-klochkov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sndmitriev @kbobrovs @bader