[SYCL][CUDA] Add backend_version device property #5802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-kanaev
reviewed
Mar 14, 2022
Comment on lines
+1158
to
+1164
| template <> | ||
| inline std::string get_device_info_host<info::device::backend_version>() { | ||
| throw runtime_error( | ||
| "Backend version feature is not supported on HOST device.", | ||
| PI_INVALID_DEVICE); | ||
| } | ||
|
|
There was a problem hiding this comment.
Do I understand correctly that it's only a stub and going to be modified in follow-up patch?
There was a problem hiding this comment.
Yes it is a stub, but we currently do not have plans for implementing it for other backends. I am not even sure what it should return for host, as it is supposed to be defined by backend specification.
There was a problem hiding this comment.
It could just throw an exception for host.
There was a problem hiding this comment.
Just a minor nit, but otherwise it LGTM.
@smaslov-intel - Do we have a plan for what to return in the L0 backend for this query?
s-kanaev
previously approved these changes
Mar 17, 2022
Comment on lines
+1158
to
+1164
| template <> | ||
| inline std::string get_device_info_host<info::device::backend_version>() { | ||
| throw runtime_error( | ||
| "Backend version feature is not supported on HOST device.", | ||
| PI_INVALID_DEVICE); | ||
| } | ||
|
|
There was a problem hiding this comment.
It could just throw an exception for host.
steffenlarsen
approved these changes
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
backend_versiondevice property that can be queried viedevice.get_info()and implements it for CUDA to return compute capability.