Skip to content

[SYCL] Do not treat sycl::half kernel argument specially #5812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

Fznamznon
Copy link
Contributor

There was some special handling added when all struct kernel arguments
were decomposed since OpenCL doesn't allow half kernel argument. Once
we've implemented conditional decomposition no special handling needed
for half type.

There was some special handling added when all struct kernel arguments
were decomposed since OpenCL doesn't allow half kernel argument. Once
we've implemented conditional decomposition no special handling needed
for half type.
@Fznamznon Fznamznon marked this pull request as ready for review March 15, 2022 10:00
@Fznamznon Fznamznon requested a review from a team as a code owner March 15, 2022 10:00
@smanna12
Copy link
Contributor

@Fznamznon, for my own understanding could you please clarify?
sycl::half is sill supported as kernel argument. This patch removes the special handling for half type due to conditional decomposition implementation.

@Fznamznon
Copy link
Contributor Author

sycl::half is sill supported as kernel argument. This patch removes the special handling for half type due to conditional decomposition implementation.

Yes, it still supported. We no longer need special treatment for sycl::half type. So, after this patch It will be processed as a struct without fields of special types.

@smanna12
Copy link
Contributor

sycl::half is sill supported as kernel argument. This patch removes the special handling for half type due to conditional decomposition implementation.

Yes, it still supported. We no longer need special treatment for sycl::half type. So, after this patch It will be processed as a struct without fields of special types.

Thanks @Fznamznon for the explanation!

@premanandrao
Copy link
Contributor

Change looks good to me. Do we have any run-time tests that use half-types that would tell us if this change is okay?

@bader bader merged commit 8924fcc into intel:sycl Mar 15, 2022
@Fznamznon
Copy link
Contributor Author

Change looks good to me. Do we have any run-time tests that use half-types that would tell us if this change is okay?

I believe we have a lot of them. For example this test - https://github.com/intel/llvm-test-suite/blob/intel/SYCL/USM/fill.cpp captures a struct (test_struct) with half value inside by value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants