[SYCL] Keep CG ownership for run_on_host_intel command nodes #5823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of commit 5373ccb, DispatchNativeKernel uses copies of the required data instead of using the associated command group object directly. This change removes the release of CG ownership from the command node since the CG is no longer deleted by DispatchNativeKernel.
sergey-semenov
force-pushed
the
runonhostintelCG
branch
from
5651dd2 to
75a1a95
Compare
|
@intel/llvm-reviewers-runtime Could someone please review this change? |
alexbatashev
approved these changes
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of commit 5373ccb
DispatchNativeKernel uses copies of the required data instead of using
the associated command group object directly. This change removes the
release of CG ownership from the command node since the CG is no longer
accessed or deleted by DispatchNativeKernel.