[ESIMD] Fix compilation from static libraries. #5826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sycl-post-link previously removed "llvm.used" global, but that was not enough as the initializer of "llvm.used" was not deleted and some elements of initializer used kernels. As a result the GenXSPIRVWriterAdaptor did not transform the kernel arguments properly thinking that the kernel was called from inside the module, which was not true. Removing the initializer fixed the issue. Signed-off-by: Vyacheslav N Klochkov <[email protected]>
v-klochkov
force-pushed
the
esimd_static_linking_fix
branch
from
ce155b8 to
c2b9568
Compare
|
@dpcpp-tools-reviewers (@AlexeySachkov , @mlychkov ) - would you please take a look at this fix. |
mlychkov
reviewed
Mar 17, 2022
|
Also may a test be included? |
Sure, the test is available here: intel/llvm-test-suite#923 |
Signed-off-by: Vyacheslav N Klochkov <[email protected]>
mlychkov
reviewed
Mar 17, 2022
Co-authored-by: Mikhail Lychkov <[email protected]>
|
/verify with intel/llvm-test-suite#923 |
kbobrovs
approved these changes
Mar 17, 2022
|
13 CI checks passed, 1 CI check shows up as pending, but it also passed. |
v-klochkov
added a commit
to v-klochkov/llvm-test-suite
that referenced
this pull request
Mar 22, 2022
The corresponding fix in the compiler: intel/llvm#5826 Signed-off-by: Vyacheslav N Klochkov <[email protected]>
vladimirlaz
pushed a commit
to intel/llvm-test-suite
that referenced
this pull request
Mar 24, 2022
…ary (#923) The corresponding fix in the compiler: intel/llvm#5826 Signed-off-by: Vyacheslav N Klochkov <[email protected]>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…ary (intel/llvm-test-suite#923) The corresponding fix in the compiler: intel#5826 Signed-off-by: Vyacheslav N Klochkov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sycl-post-link previously removed "llvm.used" global, but that was
not enough as the initializer of "llvm.used" was not deleted and
some elements of initializer used kernels.
As a result the GenXSPIRVWriterAdaptor did not transform the kernel
arguments properly thinking that the kernel is called from another kernel,
which was not true.
Removing the initializer fixed the issue.
Signed-off-by: Vyacheslav N Klochkov [email protected]