[ESIMD] Fix removal of "llvm.used" global in sycl-post-link #5853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code removing llvm.used global in sycl-post-link wrongly assumed that all elements of the global array are either functions or function declarations. In fact llvm.used also may contain specialization constants as well. The fix adds additional check of IR before removal. Signed-off-by: Vyacheslav N Klochkov <[email protected]>
ghost
reviewed
Mar 22, 2022
| @@ -859,10 +859,11 @@ static bool removeSYCLKernelsConstRefArray(GlobalVariable *GV) { | |||
| for (auto It = IOperands.begin(); It != IOperands.end(); It++) { | |||
There was a problem hiding this comment.
Suggested change
| for (auto It = IOperands.begin(); It != IOperands.end(); It++) { | |
| for (auto *It = IOperands.begin(); It != IOperands.end(); It++) { |
There was a problem hiding this comment.
The suggested change is NFC, both syntax variants mean the same here.
I prefer 'auto It = ...'. It is also way more typical syntax (about 2000 cases in sources vs 54 cases of 'auto *It = ' )
AlexeySachkov
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code removing llvm.used global in sycl-post-link wrongly
assumed that all elements of the global array are either functions
or function declarations. In fact llvm.used also may contain specialization
constants as well.
The fix adds additional check of IR before removal.
Signed-off-by: Vyacheslav N Klochkov [email protected]