Skip to content

[SYCL][NFC][DOC] Add esimd_emulator to SYCL_DEVICE_FILTER description #5857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

denis-kabanov
Copy link
Contributor

According to 4020, esimd_emulator is a possible value for backend in SYCL_DEVICE_FILTER.

@denis-kabanov denis-kabanov requested a review from a team as a code owner March 22, 2022 12:32
@denis-kabanov denis-kabanov changed the title [SYCL][NFC] Add esimd_emulator to SYCL_DEVICE_FILTER description [SYCL][NFC][DOC] Add esimd_emulator to SYCL_DEVICE_FILTER description Mar 22, 2022
@bader bader requested a review from a team March 22, 2022 12:41
Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with the change, but I'd like ESIMD team to approve the variable value name before merging.

@s-kanaev
Copy link
Contributor

s-kanaev commented Apr 1, 2022

@intel/dpcpp-esimd-reviewers , a friendly ping

@bader
Copy link
Contributor

bader commented Apr 6, 2022

@intel/dpcpp-esimd-reviewers, ping. Could you confirm that your are okay with proposed SYCL_DEVICE_FILTER value change?
@pvchupin, FYI.

@bader bader merged commit 526ad0c into intel:sycl Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants