[SYCL] Add support for get_native for buffer and fix backend_return_t #5881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/verify with intel/llvm-test-suite#945 |
|
/verify with intel/llvm-test-suite#945 |
|
In #4952, we were concerned about breaking ABI / API compatibility when we changed the return type of |
|
@gmlueck Yes, I think we should apply the same logic |
gmlueck
previously approved these changes
Apr 4, 2022
|
@s-kanaev could you please review? |
|
/verify with intel/llvm-test-suite#945 |
s-kanaev
reviewed
Apr 5, 2022
Comment on lines
81
to
84
| template <typename DataT, int Dimensions, typename AllocatorT> | ||
| struct interop<backend::opencl, buffer<DataT, Dimensions, AllocatorT>> { | ||
| using type = cl_mem; | ||
| }; |
There was a problem hiding this comment.
Where is this type used? Is it needed?
There was a problem hiding this comment.
It seems it is not used anywhere. I removed it
againull
approved these changes
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for sycl::get_native(sycl::buffer) accordingly to the spec.
Also, fixed backend_return_t for buffer for OpenCL backend.
Signed-off-by: mdimakov [email protected]