Skip to content

[SYCL][XPTI] Added kernel info #5887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 5, 2022
Merged

[SYCL][XPTI] Added kernel info #5887

merged 8 commits into from
Apr 5, 2022

Conversation

vladimirlaz
Copy link
Contributor

@vladimirlaz vladimirlaz commented Mar 25, 2022 •
edited
Loading 

 - kernel execution parameter (global size, local size, offset)
 - kernel argument parameters (number, size, pointer which can be
associated with accessor/USM buffer)

E2E tests: intel/llvm-test-suite#949

@vladimirlaz
[SYCL][XPTI] Added kernel info
7bf1ce6 
     - kernel execution parameter (global size, local size, offset)
     - kernel argument parameters (number, size, pointer which can be
    associated with accessor/USM buffer)
@vladimirlaz vladimirlaz requested a review from a team as a code owner March 25, 2022 08:18
@vladimirlaz vladimirlaz requested a review from a team as a code owner March 29, 2022 07:21
@vladimirlaz
Copy link
Contributor Author

Test failures unrelated to the change and are going to be fixed in separate PRs.

@bader
Copy link
Contributor

bader commented Mar 29, 2022

Test failures unrelated to the change and are going to be fixed in separate PRs.

... which should go in before this patch. :)

@gmlueck
Copy link
Contributor

gmlueck commented Mar 29, 2022

vladimirlaz requested a review from https://github.com/orgs/intel/teams/dpcpp-specification-reviewers as a code owner 5 hours ago

I'm not sure you need a reviewer from dpcpp-specification-reviewers for this, as it does not impact any SYCL API specification.

alexbatashev
alexbatashev reviewed Mar 30, 2022
View reviewed changes
@vladimirlaz
Copy link
Contributor Author

/summary:run

@alexbatashev
Copy link
Contributor

/summary:run

@vladimirlaz vladimirlaz requested a review from alexbatashev April 1, 2022 04:54
alexbatashev
alexbatashev suggested changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@alexbatashev alexbatashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we re-use existing events form sycl stream and extend them with metadata?

@vladimirlaz vladimirlaz requested a review from alexbatashev April 3, 2022 16:21
@vladimirlaz
Copy link
Contributor Author

@alexbatashev failure in GHA looks like infra issue. Could you please have a look/fix/restart?

@vladimirlaz
Copy link
Contributor Author

@alexbatashev It looks like the same environment issue...

@vladimirlaz
Copy link
Contributor Author

/summary:run

@vladimirlaz vladimirlaz mentioned this pull request Apr 4, 2022
Merged
@vladimirlaz vladimirlaz merged commit 4b9eef3 into intel:sycl Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexbatashev alexbatashev alexbatashev approved these changes

@smaslov-intel smaslov-intel Awaiting requested review from smaslov-intel smaslov-intel is a code owner automatically assigned from intel/llvm-reviewers-runtime

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vladimirlaz @bader @gmlueck @alexbatashev