[SYCL][sycl-post-link] Makes device_global property names consistent

[steffenlarsen]

This commit changes the IR attributes expected for device_global properties more consistent with other sycl-related IR attributes, i.e. the naming being prefixed by "sycl-" and replacing "_" with "-".

[ghost]

@steffenlarsen @gmlueck I took the names for the properties from the design document. Should the design document be updated as well?

[ghost]

@steffenlarsen Also, there is a reference to the device_image_scope property in an error message: https://github.com/intel/llvm/blob/sycl/llvm/tools/sycl-post-link/ModuleSplitter.cpp#L266

[steffenlarsen]

I took the names for the properties from the design document. Should the design document be updated as well?

Nothing was set in stone for the "meta-names" (i.e. their names as LLVM IR attributes) of the properties as the design document did not specify them. "sycl-device-global-size" uses a naming scheme like the one in these changes, so it makes the IR attributes more consistent. As such I don't believe we need changes to the design document for this.

In an upcoming patch I add a common way for defining "meta-names". As part of it, it specifies this as typical naming for the meta-names, so hopefully it should not cause any confusion in the future.

Also, there is a reference to the device_image_scope property in an error message: https://github.com/intel/llvm/blob/sycl/llvm/tools/sycl-post-link/ModuleSplitter.cpp#L266

That is fine. It refers to the property which is still device_image_scope.

[ghost]

That is fine. It refers to the property which is still device_image_scope.

But I see that in the tests you have renamed the property to sycl-device-image-scope. Do I get it right, in C++ this property is still device_image_scope but in the IR this will be named sycl-device-image-scope?

[steffenlarsen]

That is fine. It refers to the property which is still device_image_scope.

But I see that in the tests you have renamed the property to sycl-device-image-scope. Do I get it right, in C++ this property is still device_image_scope but in the IR this will be named sycl-device-image-scope?

Yeah, so in the LLVM IR the attribute for the device_image_scope property will be named sycl-device-image-scope. I tried my best to keep device_image_scope (and other property names) in the places where they are mentioned as properties and not attributes. I don't see any cases I missed, but please let me know if you find some.

[ghost]

@steffenlarsen Thank you for the explanation. Now the patch LGTM.