Skip to content

[ESIMD] Disable ABI changes warnings in host compiler. #5931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2022
Merged

[ESIMD] Disable ABI changes warnings in host compiler. #5931

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions sycl/include/sycl/ext/intel/esimd.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,14 @@

/// @} sycl_esimd

// TODO Disable "changes ABI" warnings emitted by host compiler, because ESIMD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Can you given an example of the warning that you see?
  2. Can't this mask potential problems with ABI differences when we use std library funcs, or something like that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

.../sycl/include/sycl/ext/intel/esimd/detail/simd_obj_impl.hpp:226:15: warning: AVX vector return of type 'cl::sycl::ext::intel::esimd::detail::simd_obj_impl<unsigned long, 16, cl::sycl::ext::intel::esimd::simd<unsigned long, 16>>::raw_vector_type' (aka 'cl::sycl::ext::intel::esimd::detail::raw_vector_type<unsigned long, 16>::type') without 'avx512f' enabled changes the ABI [-Wpsabi]
    set(other.data());
              ^
  1. No. I tried to explain why in the comment.

// code is supposed to be compiled by clang++ only for now anyway, plus ESIMD
// code performance on host is not an issue yet.
#if !defined(__SYCL_DEVICE_ONLY__) && defined(__clang__)
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wpsabi"
#endif // !defined(__SYCL_DEVICE_ONLY__) && defined(__clang__)

#include <sycl/ext/intel/esimd/alt_ui.hpp>
#include <sycl/ext/intel/esimd/common.hpp>
#include <sycl/ext/intel/esimd/math.hpp>
Expand All @@ -79,3 +87,7 @@
#include <sycl/ext/intel/esimd/simd_view.hpp>
#include <sycl/ext/intel/experimental/esimd/math.hpp>
#include <sycl/ext/intel/experimental/esimd/memory.hpp>

#if !defined(__SYCL_DEVICE_ONLY__) && defined(__clang__)
#pragma clang diagnostics pop
#endif // !defined(__SYCL_DEVICE_ONLY__) && defined(__clang__)