Skip to content

[SYCL][Test] Add integration test to verify SPIR kernel argument names #5942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mlychkov
Copy link
Contributor

@mlychkov mlychkov commented Apr 1, 2022

It validates that user specified names in kernel lambda object are saved
till processing by back-ends.

Signed-off-by: Mikhail Lychkov [email protected]

mlychkov added 2 commits April 1, 2022 10:34
It validates that user specified names in kernel lambda object are saved
till processing by back-ends.

Signed-off-by: Mikhail Lychkov <[email protected]>
@mlychkov mlychkov requested a review from a team as a code owner April 1, 2022 10:35
@mlychkov mlychkov requested a review from s-kanaev April 1, 2022 10:35
s-kanaev
s-kanaev previously approved these changes Apr 1, 2022
@bader bader merged commit ff2f0f9 into intel:sycl Apr 5, 2022
@mlychkov mlychkov deleted the private/mlychkov/kernel_arg_names_integr_test branch April 5, 2022 18:58
@bader
Copy link
Contributor

bader commented Apr 6, 2022

@mlychkov, this test fails for "no assertions" build - https://github.com/intel/llvm/runs/5836585271?check_suite_focus=true.

Tagging @pvchupin, @againull, to follow-up.

@mlychkov
Copy link
Contributor Author

mlychkov commented Apr 6, 2022

I suppose it is due to simplification of variables names to numbers in LLVM IR if release build is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants