[SYCL][ESIMD] Change arguments of some APIs to be template parameters #5961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/verify with intel/llvm-test-suite#974 |
kbobrovs
previously approved these changes
Apr 6, 2022
kychendev
reviewed
Apr 13, 2022
| @@ -790,6 +798,10 @@ __ESIMD_API void barrier() { | |||
| /// @{ | |||
|
|
|||
| /// Declare per-work-group slm size. | |||
| /// @tparam size slm size | |||
| template <uint32_t size> __ESIMD_API void slm_init() { __esimd_slm_init(size); } | |||
There was a problem hiding this comment.
This will break the planned change to support variable size for slm_init.
This is needed to force them to be compile-time constants which is required by low-level intrinsics. Signed-off-by: Sergey Dmitriev <[email protected]>
…scatter intrinsics This is needed to satisfy requirement for the 2nd argument of low-level svm.gather/scatter intrinsics to be a constant. This was not guaranteed earlier.
…mpat. Signed-off-by: Konstantin S Bobrovsky <[email protected]>
kbobrovs
force-pushed
the
sndmitriev/esimd-deprecated
branch
from
9b00a01 to
0be396b
Compare
…c const version. Signed-off-by: Konstantin S Bobrovsky <[email protected]>
kbobrovs
reviewed
Apr 17, 2022
kbobrovs
reviewed
Apr 17, 2022
kbobrovs
reviewed
Apr 17, 2022
kbobrovs
reviewed
Apr 18, 2022
kbobrovs
reviewed
Apr 19, 2022
v-klochkov
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to force them to be compile-time constants which is required
by low-level intrinsics.
Signed-off-by: Sergey Dmitriev [email protected]