[SYCL][L0] Improve L0 timestamps #6006
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jandres742
force-pushed
the
fixL0timestamps
branch
2 times, most recently
from
dde0594 to
18bf9b2
Compare
- Timer resolution is returned by L0 by default on nanoseconds. - Properly mask kernel timestamp based on valid bits. - Return ContextEndTime as end time, not as delta wrt start. Signed-off-by: Jaime Arteaga <[email protected]>
| 1ULL) | ||
| : ((1ULL << Event->Context->Devices[0] | ||
| ->ZeDeviceProperties->kernelTimestampValidBits) - | ||
| 1ULL); |
There was a problem hiding this comment.
Please compute device first and the use it 5146-5158 to make it cleaner
There was a problem hiding this comment.
@smaslov-intel : Please see here #6010
| @@ -5157,27 +5164,27 @@ pi_result piEventGetProfilingInfo(pi_event Event, pi_profiling_info ParamName, | |||
| switch (ParamName) { | |||
| case PI_PROFILING_INFO_COMMAND_START: { | |||
| ZE_CALL(zeEventQueryKernelTimestamp, (Event->ZeEvent, &tsResult)); | |||
| uint64_t ContextStartTime = tsResult.context.kernelStart * ZeTimerFreq; | |||
| uint64_t ContextStartTime = | |||
| (tsResult.context.kernelStart & TimestampMaxValue) * ZeTimerResolution; | |||
There was a problem hiding this comment.
Does it mean that the Level-Zero spec guidance needs to be adjusted?
https://spec.oneapi.io/level-zero/latest/core/PROG.html#kernel-timestamp-events
There was a problem hiding this comment.
@smaslov-intel if you are referring to
const double timestampFreq = NS_IN_SEC / device_properties.timerResolution;this is valid only if you use ZE_STRUCTURE_TYPE_DEVICE_PROPERTIES_1_2
uint64_t timerResolution
[out] Returns the resolution of device timer used for profiling, timestamps, etc.
When stype==ZE_STRUCTURE_TYPE_DEVICE_PROPERTIES the units are in nanoseconds.
When stype==ZE_STRUCTURE_TYPE_DEVICE_PROPERTIES_1_2 units are in cycles/secis that what you are referring to or something else in the spec?
| const uint64_t TimestampMaxValue = | ||
| (1LL << Device->ZeDeviceProperties->kernelTimestampValidBits) - 1; | ||
| ContextEndTime += TimestampMaxValue - ContextStartTime; | ||
| ContextEndTime += TimestampMaxValue; |
smaslov-intel
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jaime Arteaga [email protected]