Skip to content

[SYCL][libdevice] Solve inline attr conflict when building libdevice #6007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2022

Conversation

jinge90
Copy link
Contributor

@jinge90 jinge90 commented Apr 13, 2022

Signed-off-by: jinge90 [email protected]

Previous patch #5979 to apply "always_inline" to all libdevice functions have some problem, so libdevice functions are required to be no-inline. Currently, we have following groups of libdevice functions:

  1. assert support //Not sure inline impact to those functions, so we don't apply always_inline to assert for safety.
  2. string support // No problem for string utils, apply always_inline
  3. cmath/cmath-fp64 //No problem for cmah utils, apply always_inline
  4. complex/complex-fp64 //No problem for complex math utils, apply always_inline
  5. ITT // Some functions in ITT support are required to be no-inline, we shouldn't apply always_inline to them.

@jinge90 jinge90 requested a review from a team as a code owner April 13, 2022 03:37
@jinge90 jinge90 requested review from againull and fadeeval April 13, 2022 03:37
@jinge90 jinge90 requested a review from v-klochkov April 13, 2022 03:40
@jinge90
Copy link
Contributor Author

jinge90 commented Apr 15, 2022

Hi, all.
Could you help review this patch?

Thanks very much.

@againull againull merged commit c044d82 into intel:sycl Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants