[SYCL][ESIMD][EMU] Clearing unused function arguments in PI module

[dongkyunahn-intel]

No description provided.

[v-klochkov]

I don't remember any agreement on this. So, this may be Ok.
In those cases where the type does not describe the parameter it is ok to omit the name, on other like 'size_t' it may be still good to have a name in comment section. For example:

Suggested change

	auto assignment = [](void *ParamValue, T Value, size_t) {
	auto assignment = [](void *ParamValue, T Value, size_t /*ValueSize*/) {

[dongkyunahn-intel]

In other plug-in implementations, (void)XXX; is used. I introduced ARG_UNUSED macro for suppressing warning messages from unused arguments.

[v-klochkov]

Because the function is not documented it may be good to have something like:

Suggested change

	pi_result piEventGetProfilingInfo(pi_event, pi_profiling_info, size_t, void *,
	size_t *) {
	pi_result piEventGetProfilingInfo(pi_event, pi_profiling_info, size_t /*ParamValueSize*/, void */*ParamValue*/,
	size_t */*ParamValueSizeRet*/) {

[v-klochkov]

This is clear/good fix.
In my opinion, it is though better to retain some additional information about the parameters, either in a comment section before the functions, or in comment section when the argument is not described by its type.

Replacing 'pi_device Device' with 'pi_device' is Ok, while replacing 'size_t *ParamVlaueSizeRet' with 'size_t *' seems like luck of information in the new code.
I noticed only the first couple of such cases explicitly as examples.

[kbobrovs]

@steffenlarsen, please review

[steffenlarsen]

LGTM!

[dongkyunahn-intel]

Unrelated failure from 'OCL Gen9 LLVM Test Suite'

Failed Tests (1):
  SYCL :: KernelAndProgram/undefined-symbol.cpp