Skip to content

[OpenCL] Uplift loader dependency to fix compilation error #6057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 26, 2022
Merged

[OpenCL] Uplift loader dependency to fix compilation error #6057

merged 5 commits into from
Apr 26, 2022

Conversation

cdai2
Copy link
Contributor

@cdai2 cdai2 commented Apr 26, 2022

The community enabled the trace mechanism in previous PR. In that PR One global variable "khrEnableTrace" is used by both c and c++ files. ICX compiler reports variable linkage issue.
It's fixed by this PR.

cdai2 added 5 commits July 4, 2019 15:34
… queue creation fails

      1, SYCL runtime will try to create out-of-order queue first.
      2, If it's created successfully, use this out-of-order queue.
      3, If not, fallback to the emulation approach with in-order queue.

Signed-off-by: Chunyang Dai <[email protected]>
The latest update fixed one compilation error on Windows.
@cdai2 cdai2 requested a review from a team as a code owner April 26, 2022 01:02
@cdai2 cdai2 requested a review from cperkinsintel April 26, 2022 01:02
@cdai2
Copy link
Contributor Author

cdai2 commented Apr 26, 2022

ping @againull. Thanks.

@pvchupin
Copy link
Contributor

@cdai2, can you update PR description please on what exact compilation problem it fixes?

@cdai2
Copy link
Contributor Author

cdai2 commented Apr 26, 2022

I updated it. Please review. @pvchupin

@pvchupin pvchupin changed the title Fix compilation error [OpenCL] Uplift loader dependency to fix compilation error Apr 26, 2022
@pvchupin pvchupin merged commit 3bb7e36 into intel:sycl Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants