[SYCL] Fix addressspace cast for _alloca #6087
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-up to PR#6050. The cast should use element type and not change type. PR#6050 incorrectly change Type* to Type** (when adding the cast) This patch also add opaque pointer version of the test. Signed-off-by: Elizabeth Andrews <[email protected]>
premanandrao
approved these changes
May 3, 2022
|
@intel/llvm-gatekeepers this PR is ready for review and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to PR#6050. The address space cast should use
element type and not change type. PR#6050 incorrectly changed
Type* to Type** (when adding the cast). This patch fixes the bug.
PR#6050 also added the cast for LLVM vector of pointer types. This
patch reverts the behavior for vector type to match old behavior (i.e.
unreachable), since it is unclear what the required behavior is in this
case and what the code which triggers unreachable would even look
like. We can modify the behavior in future if we hit that case in some
scenario.
This patch also adds an opaque pointer version of the test.
Signed-off-by: Elizabeth Andrews [email protected]