Skip to content

[SYCL][DOC] Update properties design to new API #6115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2022

Conversation

gmlueck
Copy link
Contributor

@gmlueck gmlueck commented May 6, 2022

We previously made some minor updates to the extension specification
for compile time properties, which affected the API. This commit just
makes some minor tweaks to the design document to bring it into
alignment with the extension spec.

We previously made some minor updates to the extension specification
for compile time properties, which affected the API.  This commit just
makes some minor tweaks to the design document to bring it into
alignment with the extension spec.
@gmlueck gmlueck requested a review from a team as a code owner May 6, 2022 18:04
@gmlueck gmlueck requested a review from steffenlarsen May 6, 2022 18:04
Copy link
Contributor

@Pennycook Pennycook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM.

Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@steffenlarsen steffenlarsen merged commit c1666d9 into intel:sycl May 9, 2022
@gmlueck gmlueck deleted the gmlueck/props-design-update branch May 9, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants