Skip to content

[ESIMD] Implement accessor based gather_rgba/scatter_rgba #6131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 11, 2022
Merged

[ESIMD] Implement accessor based gather_rgba/scatter_rgba #6131

merged 4 commits into from
May 11, 2022

Conversation

v-klochkov
Copy link
Contributor

No description provided.

@v-klochkov v-klochkov changed the title Esimd gather rgba acc [ESIMD] Implement accessor based gather_rgba/scatter_rgba May 10, 2022
@v-klochkov
Copy link
Contributor Author

v-klochkov commented May 10, 2022 •
edited
Loading

The corresponding changes in LIT tests are: intel/llvm-test-suite#1022

@v-klochkov v-klochkov marked this pull request as ready for review May 10, 2022 14:34
@v-klochkov v-klochkov requested a review from a team as a code owner May 10, 2022 14:34
@v-klochkov v-klochkov requested a review from kbobrovs May 10, 2022 14:36
@v-klochkov
Copy link
Contributor Author

/verify with intel/llvm-test-suite#1022

@v-klochkov v-klochkov mentioned this pull request May 11, 2022
Merged
@kbobrovs kbobrovs merged commit 0b4c123 into intel:sycl May 11, 2022
@kbobrovs
Copy link
Contributor

One comment which can be applied as a separate PR is default RGBAMask template parameter value to channel_mask::ABGR

@v-klochkov v-klochkov deleted the esimd_gather_rgba_acc branch May 11, 2022 23:30
@v-klochkov
Copy link
Contributor Author

One comment which can be applied as a separate PR is default RGBAMask template parameter value to channel_mask::ABGR

Thank you. I uploaded the fix to make ABGR default value for rgba mask in gather/scatter: #6141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbobrovs kbobrovs kbobrovs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@v-klochkov @kbobrovs