Skip to content

[NFC] Update driver tests to not require clang-driver #6136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 12, 2022

Conversation

mdtoguchi
Copy link
Contributor

@mdtoguchi mdtoguchi commented May 10, 2022

The REQUIRES: clang-driver setting in the SYCL driver tests is
no longer valid. Remove this check as it was causing these tests
to not be supported and not run.

The REQUIRES: clang-driver setting in the SYCL driver tests is
no longer valid.  Remove this check as it was causing these tests
to not be supported and not run.
@mdtoguchi mdtoguchi requested a review from a team as a code owner May 10, 2022 21:28
@mdtoguchi mdtoguchi changed the title [NFC] Update driver tests to not require clang-driver [Driver] Update driver tests to not require clang-driver May 10, 2022
@mdtoguchi mdtoguchi changed the title [Driver] Update driver tests to not require clang-driver [NFC] Update driver tests to not require clang-driver May 10, 2022
@mdtoguchi
Copy link
Contributor Author

@intel/llvm-gatekeepers, this is ready for merge.

@bader bader merged commit a6e5617 into intel:sycl May 12, 2022
@pvchupin
Copy link
Contributor

@mdtoguchi, there is post-commit fail on windows: https://github.com/intel/llvm/actions/runs/2314201910

Clang :: Driver/sycl-intelfpga-static-lib-win.cpp

Can you take a look?

@mdtoguchi
Copy link
Contributor Author

@mdtoguchi, there is post-commit fail on windows: https://github.com/intel/llvm/actions/runs/2314201910

Clang :: Driver/sycl-intelfpga-static-lib-win.cpp

Can you take a look?

@pvchupin, I'll take a look - Not sure why pre-commit wouldn't catch this.

@bader
Copy link
Contributor

bader commented May 12, 2022

Not sure why pre-commit wouldn't catch this.

AFAIK, pre-commit doesn't run checks on Windows platform.

@mdtoguchi
Copy link
Contributor Author

test update here: #6147

@pvchupin
Copy link
Contributor

Thanks Mike for quick turnaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants