Revert "In MSVC compatibility mode, friend function declarations beha… #6143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve as function declarations" This reverts commit ad47114. Temporary workaround for intel#6142 Reverting while there is a discussion at https://reviews.llvm.org/D124613 Will return back with the appropriate fix.
smanna12
approved these changes
May 12, 2022
|
Is the revert required along with #6144? |
|
@elizabethandrews, #6144 is another possible way to fix the problem. Actually #6144 would be cleaner, since don't need to do temporary revert, but there are more related problems it seem. Posted there. I think we should proceed with this revert for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ve as function declarations"
This reverts commit ad47114.
Temporary workaround for #6142
Reverting while there is a discussion at https://reviews.llvm.org/D124613
Will return back with the appropriate fix from community as soon as done.