[SYCL][HIP] Improve instructions for non standard installations #6145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bader
approved these changes
May 12, 2022
There was a problem hiding this comment.
LGTM.
In addition to that, it might be useful to have a variable to set ROCm installation root directory as it seems that all three variables from the example point to the standard pre-defined locations within the root directory. Having such "root directory" variable should make configuration easier.
pvchupin
pushed a commit
that referenced
this pull request
Aug 2, 2022
Use a single CMake variable for the root of the ROCm installation rather than three for the hip include directory, the hip library and the hsa include directories. And add a clear CMake error when the ROCm installation doesn't exist. This was discussed a little while back in #6145 and should make working with non-standard ROCm installation easier and clearer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was discussed in: #6091