[SYCL][CUDA] fix warnings in async barrier #6165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
20
to
22
| #ifdef __SYCL_DEVICE_ONLY__ | ||
| int64_t state; | ||
| #endif |
There was a problem hiding this comment.
This means that barrier will have different size on the host and the device. Since it is used in local memory it may not be a problem, but I would feel safer if instead of making the class structure different we instead marks it used (using (void)state;) in some function, e.g. initialize.
steffenlarsen
approved these changes
May 18, 2022
yinyangsx
pushed a commit
to yinyangsx/llvm
that referenced
this pull request
May 25, 2022
Fixes warnings introduced in intel#5303. Co-authored-by: Artur Gainullin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes warnings introduced in #5303.