[SYCL][libdevice] Add -fsycl-device-lib-online-link option. #6167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When this option is used, we use online link for SYCL device libraries, otherwise, we use offline link, all wrapper and fallback device libraries are linked with user's device image in compilation time. Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
|
@jinge90, can you please add update of https://github.com/intel/llvm/blob/sycl/sycl/doc/UsersManual.md into this patch? |
pvchupin
reviewed
May 25, 2022
…or the option Signed-off-by: jinge90 <[email protected]>
Doc added. |
pvchupin
previously approved these changes
May 26, 2022
Co-authored-by: Pavel Chupin <[email protected]>
|
Hi, @mdtoguchi Thanks very much. |
pvchupin
approved these changes
May 26, 2022
pvchupin
pushed a commit
that referenced
this pull request
Jun 2, 2022
Currently, sycl-post-link tool will analyze user's device image and record which device libraries are actually required by user, sycl runtime will read the info and load the required fallback spv file. However, old compiler would always mark "cassert" fallback spv as required, this was to bypass a FE issue. So, if anyone uses old compiler + new SYCL runtime with online link enabled, unnecessary cassert fallback spv loading will be observed. This PR will ignore "cassert" fallback spv in sycl runtime, ignoring it is OK for now since "cassert" fallback has not been fully implemented. This PR depends on #6167 Signed-off-by: jinge90 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this option is used, we use online link for SYCL device libraries,
otherwise, we use offline link, all wrapper and fallback device libraries
are linked with user's device image in compilation time.
Signed-off-by: jinge90 [email protected]