[SYCL] Fix returned alignment of allocation functions #6205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A test is being added in intel/llvm-test-suite#1042.
aelovikov-intel
commented
May 26, 2022
| @@ -158,7 +158,8 @@ T *malloc_device( | |||
| const property_list &PropList = {}, | |||
| const detail::code_location CodeLoc = detail::code_location::current()) { | |||
| return static_cast<T *>( | |||
| malloc_device(Count * sizeof(T), Dev, Ctxt, PropList, CodeLoc)); | |||
| aligned_alloc_device(std::max(alignof(T), alignof(std::max_align_t)), | |||
There was a problem hiding this comment.
@gmlueck , after reading your comment in the llvm-test-suite PR I think this is overly pessimistic and should be just alignof(T) without any std::max. Would you agree?
There was a problem hiding this comment.
Yes, you are correct. In fact, the spec says this:
No alignment parameter; Templated on allocation type
T
Pointer is suitably aligned for an object of typeT.
Thanks for noticing.
againull
approved these changes
May 26, 2022
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
May 31, 2022
againull
pushed a commit
that referenced
this pull request
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A test is being added in intel/llvm-test-suite#1042.