Skip to content

[SYCL] Fix unittest crashes after PR #6128 #6206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2022

Conversation

aelovikov-intel
Copy link
Contributor

We need to destroy resources when the Ctx object is destructed. Otherwise the
destruction of internal RT objects would be delayed until global context
destruction that happens after ~PiMock.

We need to destroy resources when the Ctx object is destructed. Otherwise the
destruction of internal RT objects would be delayed until global context
destruction that happens *after* ~PiMock.
@aelovikov-intel aelovikov-intel requested a review from a team as a code owner May 26, 2022 19:54
Copy link
Contributor

@cperkinsintel cperkinsintel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this fixes the error we saw?

LGTM! ( Lovely Girls Terrify Me )

@againull againull merged commit 7384e43 into intel:sycl May 26, 2022
@aelovikov-intel aelovikov-intel deleted the fix-pi-mock branch November 8, 2022 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants