Skip to content

[SYCL][PI] Add versioning for plugins #6216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Jun 17, 2022
Merged

[SYCL][PI] Add versioning for plugins #6216

merged 21 commits into from
Jun 17, 2022

Conversation

hdelan
Copy link
Contributor

@hdelan hdelan commented May 31, 2022

Following on from #5412

@hdelan hdelan requested review from a team as code owners May 31, 2022 09:42
@hdelan hdelan requested a review from smaslov-intel May 31, 2022 09:42
@hdelan hdelan changed the title Adding versioning for plugins [SYCL][PI] Add versioning for plugins May 31, 2022
@hdelan hdelan requested a review from steffenlarsen May 31, 2022 14:04
@steffenlarsen
Copy link
Contributor

CI (6672610140) seems to have choked on setup. Rerunning.

@cperkinsintel
Copy link
Contributor

The failures in the CI are occurring when running SYCL_PI_TRACE=-1 sycl-ls

I'm guessing they are legitimate failures somehow introduced by this PR.

@hdelan
Copy link
Contributor Author

hdelan commented May 31, 2022

Going on holiday tomorrow - will pick this back up in 2 weeks!

@hdelan
Copy link
Contributor Author

hdelan commented Jun 14, 2022

The failures in the CI are occurring when running SYCL_PI_TRACE=-1 sycl-ls

I'm guessing they are legitimate failures somehow introduced by this PR.

Seems to be a problem with esimd stuff. Will investigate

@hdelan
Copy link
Contributor Author

hdelan commented Jun 14, 2022

The failures in the CI are occurring when running SYCL_PI_TRACE=-1 sycl-ls

I'm guessing they are legitimate failures somehow introduced by this PR.

Should be fixed now

@hdelan hdelan closed this Jun 14, 2022
@hdelan hdelan reopened this Jun 14, 2022
steffenlarsen
steffenlarsen previously approved these changes Jun 15, 2022
@pvchupin pvchupin requested a review from smaslov-intel June 15, 2022 21:06
@hdelan hdelan requested review from a team as code owners June 16, 2022 10:36
@hdelan hdelan closed this Jun 16, 2022
@hdelan hdelan reopened this Jun 16, 2022
@hdelan
Copy link
Contributor Author

hdelan commented Jun 16, 2022

Failure coming from Reduction/reduction_usm.cpp which is unrelated to this PR

@pvchupin pvchupin requested a review from smaslov-intel June 16, 2022 22:59
@pvchupin pvchupin merged commit bf0fc43 into intel:sycl Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants