[FPGA][NFC] Refactor [[intel::max_work_group_size()]] attribute tests #6240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bute This patch updates test bases for [[intel::max_work_group_size()]] attribute: 1. separates AST and diagnostics to make it easier to read/follow-up. 2. removes duplicate test cases. 3. no compiler changes. Signed-off-by: Soumi Manna <[email protected]>
smanna12
changed the title
Signed-off-by: Soumi Manna <[email protected]>
bader
changed the title
premanandrao
reviewed
Jun 3, 2022
Signed-off-by: Soumi Manna <[email protected]>
elizabethandrews
approved these changes
Jun 3, 2022
premanandrao
approved these changes
Jun 3, 2022
|
Thank you for reviews everyone. |
|
The failures are not related to my patch. @intel/llvm-gatekeepers, this PR is ready for a merge. Thank you |
|
Fails addressed at intel/llvm-test-suite#1044 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates test bases for [[intel::max_work_group_size()]] attribute:
Signed-off-by: Soumi Manna [email protected]