[SYCL] Protect access to the pi_context, pi_device and pi_platform #6244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove limit for commandlists in the cache. * Protect access to ZeCache with its own mutex. Access to ZeCache using -> can trigger computation of the property and we don't know when this is going to happen, so need to use unique_lock for each access because each access can potentially do write. * Remove unnecessary device locks considering ZeCache properties are guarded with their own lock, many data members are const and other members like SubDevices and QueueGroup vectors are calculated only once during caching of devices and its subdevices. * Lock context for shared access in piextUSMDeviceAlloc and piextUSMHostAlloc.
smaslov-intel
approved these changes
Jun 13, 2022
|
@againull, please fix post-commit issue on Windows: https://github.com/intel/llvm/runs/6865665237?check_suite_focus=true |
steffenlarsen
added a commit
to steffenlarsen/llvm
that referenced
this pull request
Jun 14, 2022
intel#6244 changed the L0 backend to use std::scoped_lock for various occasions. However, when building with MSVC some of the uses are done through copying. Since std::scoped_lock has its copy-constructor deleted this causes the build to fail. This commit changes this pattern to avoid the copy. Signed-off-by: Larsen, Steffen <[email protected]>
pvchupin
pushed a commit
that referenced
this pull request
Jun 14, 2022
#6244 changed the L0 backend to use std::scoped_lock for various occasions. However, when building with MSVC some of the uses are done through copying. Since std::scoped_lock has its copy-constructor deleted this causes the build to fail. This commit changes this pattern to avoid the copy. Signed-off-by: Larsen, Steffen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.