Skip to content

[SYCL][CUDA] Ignore and warn for mem-advise when requirement not met #6281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

steffenlarsen
Copy link
Contributor

@steffenlarsen steffenlarsen commented Jun 9, 2022

Similar to cuMemPrefetchAsync, cuMemAdvise may require that a device supports concurrent managed memory access. These changes makes cuda_piextUSMEnqueueMemAdvise ignore and warn for a number of memory advises if the device does not meet the aforementioned requirement.

Similar to cuMemPrefetchAsync, cuMemAdvise may require that a device
supports concurrent managed memory access. These changes makes
cuda_piextUSMEnqueueMemAdvise ignore and warn when a number of memory
advises if the device does not meet the aforementioned requirement.

Signed-off-by: Larsen, Steffen <[email protected]>
@steffenlarsen steffenlarsen requested a review from a team as a code owner June 9, 2022 13:21
AidanBeltonS
AidanBeltonS previously approved these changes Jun 9, 2022
Copy link
Contributor

@AidanBeltonS AidanBeltonS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Prefetch looks much cleaner

Signed-off-by: Larsen, Steffen <[email protected]>
@pvchupin pvchupin merged commit ccaaa99 into intel:sycl Jun 9, 2022
@steffenlarsen steffenlarsen deleted the steffen/cuda_memadvise_conc_managed_access_req branch December 6, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants