Skip to content

[Driver][SYCL] Improve deprecation messaging #6282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

mdtoguchi
Copy link
Contributor

Certain options are deprecated and will be removed in a future release
timeframe. Mark such options as deprecated so they emit a diagnostic
stating as such. This was done by adding an additional option flag
which can be applied to any option that is deprecated.

Certain options are deprecated and will be removed in a future release
timeframe.  Mark such options as deprecated so they emit a diagnostic
stating as such.  This was done by adding an additional option flag
which can be applied to any option that is deprecated.
@mdtoguchi mdtoguchi requested review from a team as code owners June 9, 2022 16:57
Copy link
Contributor

@pvchupin pvchupin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mike for taking care of this!

@pvchupin
Copy link
Contributor

pvchupin commented Jun 9, 2022

@mdtoguchi, can you cross-check please against https://github.com/intel/llvm/blob/sycl/sycl/doc/UsersManual.md and make sure it matches.

@mdtoguchi
Copy link
Contributor Author

@pvchupin, all options marked as DEPRECATED in UsersManual.md are accounted for.

@pvchupin
Copy link
Contributor

pvchupin commented Jun 9, 2022

Pending @hchilama review.

@pvchupin pvchupin merged commit f0b65a1 into intel:sycl Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants