[SYCL] Fix usage of std::conditional_variable in sycl::event #6284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR intel#6245 introduced a misuse of it. I've misunderstood The notifying thread does not need to hold the lock on the same mutex as the one held by the waiting thread(s) from https://en.cppreference.com/w/cpp/thread/condition_variable/notify_all Instead, https://en.cppreference.com/w/cpp/thread/condition_variable The thread that intends to modify the shared variable has to... should be followed.
|
@intel/llvm-gatekeepers , PR is ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #6245 introduced a misuse of it. I've misunderstood
from https://en.cppreference.com/w/cpp/thread/condition_variable/notify_all
Instead, https://en.cppreference.com/w/cpp/thread/condition_variable
should be followed.