Skip to content

[SYCL][libdevice] Add SIMD emulation APIs for imf libdevice #6327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Jul 28, 2022
Merged

[SYCL][libdevice] Add SIMD emulation APIs for imf libdevice #6327

merged 19 commits into from
Jul 28, 2022

Conversation

jinge90
Copy link
Contributor

@jinge90 jinge90 commented Jun 20, 2022

Signed-off-by: jinge90 [email protected]

@jinge90 jinge90 requested review from a team as code owners June 20, 2022 03:11
@jinge90 jinge90 requested a review from v-klochkov June 20, 2022 03:11
@jinge90 jinge90 marked this pull request as draft June 20, 2022 03:11
v-klochkov
v-klochkov reviewed Jun 21, 2022
View reviewed changes
@v-klochkov
Copy link
Contributor

Is there some testing plan for this fix (LIT/unit tests)?

@jinge90
Copy link
Contributor Author

jinge90 commented Jun 24, 2022

Is there some testing plan for this fix (LIT/unit tests)?

I am also working on some tests for those imf simd emulate functions and will create PR in intel/llvm-test-suite.

Thanks very much.

jinge90 added 14 commits June 24, 2022 16:46
@jinge90
Add __imf_vcmp* functions part1
9eadc0e 
Signed-off-by: jinge90 <[email protected]>
@jinge90
fix clang-format
482d684 
Signed-off-by: jinge90 <[email protected]>
@jinge90
add __imf_vset* APIs
5ed3c06 
Signed-off-by: jinge90 <[email protected]>
@jinge90
Remove redundant code for simd unary op
ccbb31d 
Signed-off-by: jinge90 <[email protected]>
@jinge90
Merge remote-tracking branch 'origin/sycl' into simd_emulate_for_imf_…
2444846 
…libdevice
@jinge90
Use __internal_v_binary/unary_op to replace all redudant code
3c28d6f 
Signed-off-by: jinge90 <[email protected]>
@jinge90
Add __imf_vsadu2/4 __imf_vsads2/4
9fb2598 
Signed-off-by: jinge90 <[email protected]>
@jinge90
Merge remote-tracking branch 'upstream/sycl' into simd_emulate_for_im…
92662ae 
…f_libdevice
@jinge90
Add all SIMD APIs
a4e60b8 
Signed-off-by: jinge90 <[email protected]>
@jinge90
Fix clang format issue
5309c30 
Signed-off-by: jinge90 <[email protected]>
@jinge90
fix incorrect __devicelib_imf_vhaddu2 name
595ce8c 
Signed-off-by: jinge90 <[email protected]>
@jinge90
Merge remote-tracking branch 'upstream/sycl' into simd_emulate_for_im…
3a7c778 
…f_libdevice
@jinge90
Fix bug in __imf_vcmplt4
e311691 
Signed-off-by: jinge90 <[email protected]>
@jinge90
Merge remote-tracking branch 'upstream/sycl' into simd_emulate_for_im…
d7bc6c5 
…f_libdevice
@jinge90 jinge90 marked this pull request as ready for review July 6, 2022 15:58
@jinge90 jinge90 requested a review from xtian-github July 6, 2022 15:59
@jinge90
Copy link
Contributor Author

jinge90 commented Jul 6, 2022

Hi, @xtian-github
This PR includes all SIMD emulate APIs for imf libdevice, could you take a look?

Thanks very much.

@jinge90
Copy link
Contributor Author

jinge90 commented Jul 6, 2022

Is there some testing plan for this fix (LIT/unit tests)?

I am also working on some tests for those imf simd emulate functions and will create PR in intel/llvm-test-suite.

Thanks very much.

Hi, @v-klochkov
intel/llvm-test-suite#1074 is the test for all functions added, local verification has passed. When this PR is approved and merged, we will merge the test.

Thanks very much.

@v-klochkov v-klochkov mentioned this pull request Jul 6, 2022
Merged
xtian-github
xtian-github previously approved these changes Jul 6, 2022
View reviewed changes
Copy link

@xtian-github xtian-github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

v-klochkov
v-klochkov previously approved these changes Jul 7, 2022
View reviewed changes
@jinge90
Copy link
Contributor Author

jinge90 commented Jul 8, 2022

Hi, @intel/dpcpp-tools-reviewers
Could you review this PR, we added some new SIMD emulation APIs in libdevice.

Thanks very much.

@jinge90
Copy link
Contributor Author

jinge90 commented Jul 11, 2022

Hi, @pvchupin
Could you take a look this PR?
Thanks very much.

@jinge90
Copy link
Contributor Author

jinge90 commented Jul 13, 2022

Hi, @pvchupin
Kind ping~

@jinge90
Copy link
Contributor Author

jinge90 commented Jul 13, 2022

Hi, @intel/dpcpp-tools-reviewers
Could you take a look of this PR?
Thanks very much.

@jinge90 jinge90 dismissed stale reviews from v-klochkov and xtian-github via 4123fb3 July 15, 2022 10:02
@jinge90
fix conflicts
4123fb3 
Signed-off-by: jinge90 <[email protected]>
@jinge90
Copy link
Contributor Author

jinge90 commented Jul 21, 2022

Hi, @v-klochkov
Could you help check if this PR can be merged now?
Thanks very much.

@v-klochkov
Copy link
Contributor

Hi, @v-klochkov Could you help check if this PR can be merged now? Thanks very much.

This PR requires approval from @intel/dpcpp-tools-reviewers. @asudarsa - can you review this fix please?

@jinge90
Copy link
Contributor Author

jinge90 commented Jul 28, 2022

Hi, @pvchupin
Could you take a look of this PR?
Thanks very much.

@pvchupin
Copy link
Contributor

ping @asudarsa

asudarsa
asudarsa approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@asudarsa asudarsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to me. Thanks.

xtian-github
xtian-github approved these changes Jul 28, 2022
View reviewed changes
Copy link

@xtian-github xtian-github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pvchupin
Copy link
Contributor

@jinge90, can you add PR description please?

@v-klochkov v-klochkov merged commit 6f0bb25 into intel:sycl Jul 28, 2022
@jinge90 jinge90 mentioned this pull request Aug 20, 2022
Merged
againull pushed a commit that referenced this pull request Aug 25, 2022
@jinge90
[SYCL] Add sycl cpp header for imf libdevice API (#6487)
830916a 
We added some imf(intel math) APIs in libdevice: #5999, #6327, those APIs are C interface which means we don't expect users to call them directly in SYCL kernel since SYCL programming uses cpp. This PR will provide cpp wrapper for those imf APIs which users can call directly in source, the approach is similar to STL , std math functions will call corresponding C math functions or compiler math builtins. The user scenario should be following:
cpp
#include <sycl/ext/intel/math.hpp>
...
float x, y, z;
z = sycl::ext::intel::math::copysign(x, y);
...
``
@jinge90 jinge90 deleted the simd_emulate_for_imf_libdevice branch August 26, 2022 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xtian-github xtian-github xtian-github approved these changes

@v-klochkov v-klochkov v-klochkov approved these changes

@asudarsa asudarsa asudarsa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jinge90 @v-klochkov @pvchupin @xtian-github @asudarsa