Skip to content

[CI] Enable llvm-test-suite in post-commit on l0_gen9 #6352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 2, 2022

Conversation

pvchupin
Copy link
Contributor

@pvchupin pvchupin commented Jun 24, 2022

  • Level up llvm-test-suite matrix resolution to reusable workflow, to be reused by top level workflows such as pre-commit or post-commit on both Linux and Windows
  • Update Windows task name to "Build + LIT" like on Linux
  • Add l0_gen9 in post-commit testing

@pvchupin pvchupin requested a review from a team as a code owner June 24, 2022 03:04
@pvchupin pvchupin closed this Jun 24, 2022
@pvchupin pvchupin reopened this Jun 24, 2022
@pvchupin pvchupin marked this pull request as draft June 24, 2022 03:45
@pvchupin pvchupin marked this pull request as ready for review June 30, 2022 05:10
* To be reused by top level workflows such as pre-commit or post-commit
on both Linux and Windows
* Update Windows task name to "Build + LIT" like on Linux
@pvchupin pvchupin changed the title [CI][NFC] Outline resolve_test_matrix to separate action [CI][NFC] Level up resolve_test_matrix to reusable workflow Jun 30, 2022
@pvchupin
Copy link
Contributor Author

CUDA fail is unrelated, discussed at intel/llvm-test-suite#975
@intel/dpcpp-devops-reviewers, please review

Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be reused by top level workflows such as pre-commit or post-commit on both Linux and Windows

I suggest we include enabling llvm-test-suite to post-commit into this PR. It's hard to tell if these changes will work for the purpose mentioned in the description. They are not enough for enabling llvm-test-suite on Windows for sure and I don't know about post-commit on Linux.

Having a real use case will help to see if these changes is the right direction.

Pavel V Chupin added 2 commits July 7, 2022 17:37
* Add post-commit testing example on single configuration (l0_gen9)
* Address code review comments
@pvchupin pvchupin changed the title [CI][NFC] Level up resolve_test_matrix to reusable workflow [CI] Enable basic llvm-test-suite in post-commit on l0_gen9 Jul 8, 2022
@pvchupin
Copy link
Contributor Author

pvchupin commented Jul 8, 2022

CUDA issue doesn't look relevant.
We've seen it before. Disabling patch: intel/llvm-test-suite#1073

@pvchupin pvchupin requested a review from bader July 8, 2022 18:14
@bader bader changed the title [CI] Enable basic llvm-test-suite in post-commit on l0_gen9 [CI] Enable llvm-test-suite in post-commit on l0_gen9 Jul 10, 2022
@pvchupin pvchupin merged commit f86766b into intel:sycl Aug 2, 2022
@pvchupin pvchupin deleted the windows-cuda branch August 2, 2022 18:52
pvchupin pushed a commit to pvchupin/llvm that referenced this pull request Aug 4, 2022
Change intel#6352 done earlier introduced
regression to SYCL nightly workflow. This change is to fix it.
pvchupin pushed a commit that referenced this pull request Aug 8, 2022
Change #6352 done earlier introduced
regression to SYCL nightly workflow. This change is to fix it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants