Skip to content

[SYCL][FPGA] Update __builtin_intel_fpga_mem #6357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 28, 2022

Conversation

premanandrao
Copy link
Contributor

@premanandrao premanandrao commented Jun 24, 2022

This is a continuation of @Fznamznon's PR #5002. Most of the changes here are from there.

According to #4980 this built-in
should take four more constant integer parameters with following default
values:

const int32_t AnchorID = -1
const int32_t TargetAnchor = 0
const int32_t Type = 0
const int32_t Cycle = 0
The old variant is still allowed for backward compatibility. In case
some parameters are not provided - default value will be emitted in
annotation string.

In addition to the state of PR #5002, this PR makes minor changes. It incorporates @mlychkov's
code review comments there and modifies the CodeGenSYCL test to accept both opaque and
non-opaque pointers.

@premanandrao premanandrao requested a review from a team as a code owner June 24, 2022 14:58
@premanandrao
Copy link
Contributor Author

The test failure isn't related to this change.

Copy link
Contributor

@elizabethandrews elizabethandrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me. Just one question. In your commit message you say - "the CodeGenSYCL test to accept both opaque and non-opaque pointers." What do you mean by this? I just see opaque pointer tests.

Also, from what I can tell, @Fznamznon's PR was not merged because spec wasn't ready and because we weren't sure if FPGA backend can handle this IR change. Are those concerns resolved? I assume backend will just ignore intrinsic it does not recognize if support has not been added yet.

@premanandrao
Copy link
Contributor Author

Looks ok to me. Just one question. In your commit message you say - "the CodeGenSYCL test to accept both opaque and non-opaque pointers." What do you mean by this? I just see opaque pointer tests.

Thank you for this. I had missed adding the non-opaque version of the test.

Also, from what I can tell, @Fznamznon's PR was not merged because spec wasn't ready and because we weren't sure if FPGA backend can handle this IR change. Are those concerns resolved? I assume backend will just ignore intrinsic it does not recognize if support has not been added yet.

Yes, someone confirmed that it will be ignored.

Copy link
Contributor

@smanna12 smanna12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants