-
Notifications
You must be signed in to change notification settings - Fork 787
[SYCL][CUDA] Add support of CUDA XPTI tracing #6373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Unfortunately, I realized that The CI seems to fail for this reason, see logs. |
b3bc957
to
be113ab
Compare
Problem: There are two possible solutions. S1: Use S2: Accept the fact that in some systems the CUPTI library cannot be found by
This solution implies modifying/guarding different parts of the code in order to deal with the lack of the CUPTI library symbols. |
S3: we can replicate the part of BTW, what is the recommended solution for versions between CMake 3.10 ( |
Thanks @bader for S3, I implemented it in the last commit and it is working. I had a look but it seems that between CMake 3.10 and 3.17 there is not a direct replacement of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one refactoring suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Only a small question.
4e4cb56
to
28788a0
Compare
Fork of #5797
This patch rebases and finalizes (similarly to #6023) the draft in #5797, which already contained the most important commits thanks to @alexbatashev.
The most relevant additions of this patch were done in CMake files, in particular
FindCUDA
CMake (deprecated) module to theFindCUDAToolkit
one in order to find cupti library by means ofCUDA_cupti_LIBRARY
. This is advisable because on some systemsFindCUDA
fails to findCUDA_cupti_LIBRARY
. This is also the case of the CI, see the log in case ofFindCUDA
is used.generated_cuda_meta.h
for generating the CUDA printer definitions, since the location of this header file seems to vary depending on the system, in case of this file is not found a warning is printed and no errors are thrown.