[SYCL][ESIMD][EMU] Updating kernel-launch API for ESIMD_EMULATOR BE #6422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Kernel launching API for ESIMD_EMULATOR is updated in order to remove dependency on std::vector type - Download URL for pre-built CM_EMU library package is updated accordingly
v-klochkov
approved these changes
Jul 11, 2022
kbobrovs
reviewed
Jul 25, 2022
| EsimdemuKernel{reinterpret_cast<fptrVoid>(InvokeKernel<DIMS>), GroupDim, | ||
| SpaceDim} | ||
| EsimdemuKernel{reinterpret_cast<fptrVoid>(InvokeKernel<DIMS>), | ||
| GroupDim.data(), SpaceDim.data()} |
There was a problem hiding this comment.
I think the new interface should then include array length, otherwise you can't guess it within EsimdemuKernel constructor code
There was a problem hiding this comment.
CM_EMU library will be updated to have size argument for dimension info. I'll post a PR for updated interface when updated library package is posted in opensource CM_EMU github repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kernel launching API for ESIMD_EMULATOR is updated in order to
remove dependency on std::vector type
Download URL for pre-built CM_EMU library package is updated
accordingly