Skip to content

[SYCL][FPGA][NFC] Refactor of ReqdWorkGroupSize attribute tests #6431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 13, 2022
Merged

[SYCL][FPGA][NFC] Refactor of ReqdWorkGroupSize attribute tests #6431

merged 2 commits into from
Jul 13, 2022

Conversation

smanna12
Copy link
Contributor

@smanna12 smanna12 commented Jul 12, 2022 •
edited
Loading

This patch updates tests for ReqdWorkGroupSize attribute:

  1. separates AST and diagnostics to make it easier to read/follow-up.
  2. removes duplicate test cases.
  3. reduces number of tests to 4 from 7 tests.
  4. no compiler changes.

Fixes #4118

Signed-off-by: Soumi Manna [email protected]

@smanna12 smanna12 marked this pull request as ready for review July 12, 2022 23:20
@smanna12 smanna12 requested a review from a team as a code owner July 12, 2022 23:20
@smanna12
Copy link
Contributor Author

CUDA failure is not related to this PR:
https://github.com/intel/llvm/runs/7311987020?check_suite_focus=true

Failed Tests (1):
SYCL :: Assert/assert_in_simultaneous_kernels.cpp

premanandrao
premanandrao approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@premanandrao premanandrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smanna12
Copy link
Contributor Author

Thanks @premanandrao for reviews.

@smanna12
Copy link
Contributor Author

@intel/llvm-gatekeepers, this PR is ready for a merge. Thank you

@v-klochkov v-klochkov merged commit f196d0b into intel:sycl Jul 13, 2022
@smanna12 smanna12 deleted the RWGA_UPDATE branch July 13, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@premanandrao premanandrao premanandrao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SYCL] Split diagnostic and AST parts for sema tests.
3 participants
@smanna12 @premanandrao @v-klochkov