[SYCL] Fix an issue with queue shortcuts with offsets #6440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix an issue where it wasn't possible to pass an init-list for dependency events vector due to an error during template parameter pack resolution.
|
Why can't we place the test inside this repo? |
Good point, a compilation test should be enough here, will move it to this repo. |
|
tests are passing. Could we get this merged? Needed in xm. |
I'm ok if my question would be answered (and possibly addressed) post-commit. I'm not ok if it will be simply ignored, though :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue where it wasn't possible to pass an init-list for dependency
events vector due to an error during template parameter pack resolution.