[SYCL][GDB] Fix op[] when called with typedef argument #6459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation of 'index' did not strip typedefs from the argument passed to it, when passed as a single number. Instead, TYPE_CODE_INT was expected. This leads to failures when calling 'accessor[arg]' using an arg that is either a typedef or something like size_t, which are considered TYPE_CODE_TYPEDEF inside GDB. The check fails and the function continues on and fails even though the argument could have been used in the int cast. Typedef stripping was added to the if condition to fix this. Signed-off-by: Nils-Christian Kempke <[email protected]>
v-klochkov
approved these changes
Jul 21, 2022
bader
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of 'index' did not strip typedefs from the argument
passed to it, when passed as a single number. Instead, TYPE_CODE_INT was
expected.
This leads to failures when calling 'accessor[arg]' using an arg that is
either a typedef or something like size_t, which are considered
TYPE_CODE_TYPEDEF inside GDB. The check fails and the function
continues on and fails even though the argument could have been used in
the int cast.
Typedef stripping was added to the if condition to fix this.
Signed-off-by: Nils-Christian Kempke [email protected]